Skip to content

Deprecate ModuleConfig.MQTTConfig.json_enabled after MQTT JSON removal#890

Open
Copilot wants to merge 2 commits intomasterfrom
copilot/deprecate-json-enabled-setting
Open

Deprecate ModuleConfig.MQTTConfig.json_enabled after MQTT JSON removal#890
Copilot wants to merge 2 commits intomasterfrom
copilot/deprecate-json-enabled-setting

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 13, 2026 •
edited
Loading

What does this PR do?

moduleConfig.mqtt.json_enabled is still present in the schema even though MQTT JSON handling was removed. This PR formally deprecates the field in protobuf while preserving wire compatibility.

  • Schema update

    • Marks ModuleConfig.MQTTConfig.json_enabled as deprecated via protobuf field option.
    • Keeps field number/type unchanged (bool, tag 6) to avoid breaking existing encoders/decoders.

  • Deprecation signaling

    • Replaces the field comment with explicit deprecation intent and behavior:
      • functionality was removed
      • field is ignored
/*
 * Deprecated: JSON packet support on MQTT was removed, and this field is ignored.
 */
bool json_enabled = 6 [deprecated = true];

Checklist before merging

  • All top level messages commented
  • All enum members have unique descriptions

New Hardware Model Acceptance Policy

Due to limited availability and ongoing support, new Hardware Models will only be accepted from Meshtastic Backers and Partners. The Meshtastic team reserves the right to make exceptions to this policy.

Alternative for Community Contributors

You are welcome to use one of the existing DIY hardware models in your PlatformIO environment and create a pull request in the firmware project. Please note the following conditions:

  • The device will not be officially supported by the core Meshtastic team.
  • The device will not appear in the Web Flasher or Github release assets.
  • You will be responsible for ongoing maintenance and support.
  • Community-contributed / DIY hardware models are considered experimental and will likely have limited or no testing.

Getting Official Support

To have your hardware model officially supported and included in the Meshtastic ecosystem, consider becoming a Meshtastic Backer or Partner. Visit meshtastic.com for more information about partnership opportunities.

Original prompt

Goal: Deprecate the moduleConfig.mqtt.json_enabled setting in the Meshtastic protobuf definitions because the underlying functionality was removed.

Context:

  • Repository: meshtastic/protobufs
  • File: meshtastic/module_config.proto
  • Current field (at commit a4c649bd3e877dab9011d9e32dc778640ec22852, around line 58): 
    bool json_enabled = 6;

Task:

  1. Update the protobuf to mark moduleConfig.mqtt.json_enabled as deprecated.
    • Use standard protobuf field deprecation options (e.g., [deprecated = true]) and/or comments as appropriate for this repo’s conventions.
    • Ensure the deprecation is clearly communicated (why it’s deprecated; that functionality was removed).
  2. If the repo has any generated code, docs, or linting that requires additional updates when fields are deprecated, make the necessary changes.
  3. Ensure any CI/tests pass.

Acceptance criteria:

  • The field is explicitly marked deprecated in the proto.
  • The change is minimal and non-breaking for existing decoders/encoders.
  • Any relevant documentation/comments are updated.

Reference URL:

The following is the prior conversation context from the user's chat exploration (may be truncated):

User: Deprecate the moduleConfig.mqtt.json_enabled setting, since the functionality was removed

Assistant: I’m blocked from proceeding until you respond to the pending authorization prompt, after which I can apply the deprecation change and open the update for review.

This pull request was created from Copilot chat.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 13, 2026 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Copilot AI changed the title [WIP] Deprecate moduleConfig.mqtt.json_enabled setting in protobuf definitions Deprecate ModuleConfig.MQTTConfig.json_enabled after MQTT JSON removal Apr 13, 2026
Copilot AI requested a review from caveman99 April 13, 2026 09:43
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 13, 2026

The latest Buf updates on your PR. Results from workflow pull-request / build (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedApr 13, 2026, 9:50 AM

@caveman99 caveman99 marked this pull request as ready for review April 14, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vidplace7 vidplace7 vidplace7 approved these changes

@thebentern thebentern thebentern approved these changes

@jp-bennett jp-bennett Awaiting requested review from jp-bennett

+1 more reviewer

@caveman99 caveman99 caveman99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@caveman99 caveman99

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CLAassistant @caveman99 @vidplace7 @thebentern